Add error-prone.picnic.tech/bugpatterns/NonStaticImport
#5191
+32
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
commented
Dec 1, 2025
...-platform-launcher/src/main/java/org/junit/platform/launcher/tagexpression/ShuntingYard.java
Show resolved
Hide resolved
...main/java/org/junit/platform/commons/support/conversion/FallbackStringToObjectConverter.java
Show resolved
Hide resolved
This was referenced Dec 1, 2025
Pankraz76
changed the title
NonStaticImportpicnic.tech/bugpatterns/NonStaticImport
Pankraz76
changed the title
picnic.tech/bugpatterns/NonStaticImporterror-prone.picnic.tech/bugpatterns/NonStaticImport
Pankraz76
changed the title
error-prone.picnic.tech/bugpatterns/NonStaticImportNonStaticImport
6 tasks
Pankraz76
changed the title
NonStaticImporterror-prone.picnic.tech/bugpatterns/NonStaticImport
Pankraz76
force-pushed
the
fix-UnnecessarilyFullyQualified-fix-convenntion-princ-fix-NonStaticImport
branch
from
838d0fe to
6b02a14
Compare
Pankraz76
force-pushed
the
fix-UnnecessarilyFullyQualified-fix-convenntion-princ-fix-NonStaticImport
branch
from
6b02a14 to
09fc8a9
Compare
- https://error-prone.picnic.tech/bugpatterns/StaticImport Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
fix-UnnecessarilyFullyQualified-fix-convenntion-princ-fix-NonStaticImport
branch
from
09fc8a9 to
27418df
Compare
Contributor
Author
|
kindly asking, if this is any good? |
6 tasks
✅ All tests passed ✅🏷️ Commit: 27418df Learn more about TestLens at testlens.app. |
This was referenced Dec 6, 2025
rickie
reviewed
Dec 11, 2025
rickie
left a comment
rickie
left a comment
There was a problem hiding this comment.
Apart from the changes in the gradle file, they changes LGTM!
| val shouldDisableErrorProne = java.toolchain.implementation.orNull == JvmImplementation.J9 | ||
| if (name == "compileJava" && !shouldDisableErrorProne) { | ||
| disable( | ||
| "AnnotateFormatMethod", // We don`t want to use ErrorProne's annotations. |
There was a problem hiding this comment.
I'm not sure about the changes in this file TBH, are they needed?
The changes in this file seem to be related to this: #5189 (comment) seems to also be related to the changes here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
error-prone.picnic.tech/bugpatterns/NonStaticImportrelated to:
UnnecessarilyFullyQualified#5189disablewarning leftovers to finalize convention principle #5190StaticImport,NonStaticImportdiffplug/spotless#2743org.junit.openrewrite.SanityCheck#5193I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations